NukeCoder

Code Authors · Joined: Dec 09, 2006 Posts: 335

Very pleased with it so far. I hope you take these as constructive comments and not as criticism as the nuke world needs this module Smile

1. You might want to consider making the 'item image' compulsory when adding a new file as otherwise it displays the dreaded red X - there doesnt appear to be any 'checks' in place to ensure an image is entered or if the value is null that the page doesnt try to display a non-existant image. I guees it is possible to alter the theme but some item may need an image and some not so altering the theme may not be the best approach.

2. If the fee is set to 0.00 is there anyway to bypass the paypal payment page?
Most of my stuff is free so taking them to the dowload link and bypassing paypal altogether if the value is 0.00 would be really useful (for me anyway). I know I could use the crappy nuke downloads module for free stuff but I like the presentation of the Shop much, much better.

XHTML Compliance
in shop/main.tpl around line 45 find

Code:

do=administer&act=item_edit&item

change to:

Code:

do=administer&act=item_edit&item

In shop/item.tpl around line 31 find

Code:

do=administer&act=item_edit&item

change to:

Code:

do=administer&act=item_edit&item

In header.tpl

Code:

LINK tags are not permitted inside TD tags so I guess we can lose the openingTD and use <rel link instead?

Site Admin Joined: Oct 25, 2004 Posts: 921

Thanks for the feedback, I'm always looking to make the Digital Shop better.

1. Good catch! I've tried to put alot of the logic into the templates so that it is more customizable. So basically for the next version you'll see an {if $item.item_image != ''} statement for image1 in the templates.

2. I didn't include a way to bypass any payment pages because it was written specifically to sell files (but I do think this is a good idea so look for it to be an option in 2.0.6).

3. You caught the suff i missed Smile

Those two links didn't exist until 2.0.3 and I must have been in a hurry and missed those &. They are actually only seen by admin, so the page should validate if the link tag is moved into the header.
Losing the <td> might cause some layout issues.
My intention was to move <link href="modules/Digital_Shop/templates/default/style.css" rel="stylesheet" into the header.php and do something like this..

Code:

if ($name = 'Digital_Shop') {
echo "<link href="modules/Digital_Shop/templates/default/style.css" rel="stylesheet".....>";
}

Thats what I do with the stylesheet for the forums also and it works very well.

Code Authors · Joined: Dec 09, 2006 Posts: 335

Thanks!
Really looking forward to 2.0.6 now Wink